Forum Replies Created

Viewing 15 replies - 1 through 15 (of 140 total)
  • Thread Starter Tyler Tork

    (@tylertork)

    I appreciate the importance of SEO, yet also I notice that all the most popular plugins have titles much shorter than yours, most only 2 or 3 words. Yet they have achieved great popularity. I think having a useful, admin-friendly, and well-documented plugin is far more important than any SEO considerations. Because a good plugin will be reviewed and linked to — as I have reviewed and linked to yours from my website — and that does much more toward SEO than a long title.

    Some suggestions follow:

    • I dislike the note suggesting people not watermark the “full” size image. As that’s the original, highest-quality image, of course they want to watermark that one if they do any of them. Instead, how about adding a note next to “full” that says, “Original image; if you watermark this you will not be able to remove watermark unless you enable backup images on the ‘image protection & backup’ tab.”
    • For deciding which sizes need to be watermarked, it would be helpful if you display the pixel dimensions associated with each size. Themes and plugins will often add entries to this list and the user won’t necessarily know how big they are.
    • In addition to selecting which size names have watermarks applied, it would be helpful to have a number field, “Don’t automatically watermark images unless they are at least ___ pixels in both dimensions” with default value maybe 500. If the original is a 64-pixel square icon, they almost certainly don’t want to add a watermark.
    • Add an option to tile the watermark.
    • I’d like the documentation to state where the backup images are stored.
    • Some plugins have an checkbox option to remove all data associated with the plugin when it’s deactivated. Since your plugin has a lot of associated data (the backed up original images), I’d like either a checkbox like this, or some reassurance that the backup images are stored in a way that they will be gone if the plugin is deleted.
    • I don’t know whether this is possible, and I haven’t tested how it works now, but I suspect that if I use the Recalculate Thumbnails plugin or similar and the “full” image is watermarked, this will result in having watermarks on all the sizes, including those I didn’t select. It would be nice to make this bulletproof if possible — for instance, if there’s a backup of the full image, that you could use some hook in the WordPress code to substitute that as the ogiginal image for resizing purposes. Interactions with other plugins are complex, I know.
    • Likewise, when the user asks to edit an image in WordPress, if the full has a watermark and you have a backup, could you supply the backup image for editing?
    • If the image is watermarked, and the image is edited in WordPress, can you intercept the save event and reapply the watermark as appropriate?
    • When an image is watermarked (or the watermark is removed) and my browser has a cached version of the image, when I view the image in the media library, I can’t see the change until I refresh the cache (Ctrl+F5). Not sure there’s anything you can do about this.
    • I’m getting more impractical as I go along. If the admin chooses to watermark the full image and doesn’t enable backup, if they have to edit the image they would do it on their PC and then re-upload it. But there’s no way in WordPress to re-upload an image and replace the original image. They might update it in the back end using FTP. But if they do that, your code has it flagged as watermarked when it is no longer watermarked. I fear that will prevent them from reapplying the watermark. Is there some way you can tell that the image was modified after you marked it? By size or timestamp for instance?
    Thread Starter Tyler Tork

    (@tylertork)

    There’s a checkbox in the options to automatically process new uploads. I agree there’s no option to automatically watermark all old images, nor do I feel that would be desirable.

    And make sure there’s not a browser cache or CDN cache of the old scaled images.

    I don’t think this plugin does what you want — you need to search for something like “fixup media” or “restore media database”. This one just operates on images already in the database to create updated scaled versions.

    Thread Starter Tyler Tork

    (@tylertork)

    I switched the theme to Twenty Twenty-One and problem still occurs. There are no other plugins active. The Firefox browser console shows:

    Uncaught ReferenceError: __webpack_require__ is not defined
        <anonymous> index.js:1
        eval themes.php:59
        js index.js:250   *** this is in your plugin ***
        __webpack_require__ index.js:80
        checkDeferredModules index.js:46
        <anonymous> index.js:153
        <anonymous> index.js:156
    index.js:1
        <anonymous> index.js:1
        eval themes.php:59
        js index.js:250
        __webpack_require__ index.js:80
        checkDeferredModules index.js:46
        <anonymous> index.js:153
        <anonymous> index.js:156
    Thread Starter Tyler Tork

    (@tylertork)

    Looks good, thanks!

    Thread Starter Tyler Tork

    (@tylertork)

    I don’t see the point in testing software you’re about to replace with a completely different implementation. I’ll wait for your new version.

    Thread Starter Tyler Tork

    (@tylertork)

    Yes, I have used the correct location ID. Even if it were incorrect, I’m not sure how that would cause a browser security violation. I also don’t know how that would affect the fact that you’re using an API that’s about to become defunct.

    Thread Starter Tyler Tork

    (@tylertork)

    I’m on Campaigns screen. One campaign is showing: https://prnt.sc/_0djHNSJzI51
    I click “No, it’s ok!” This is the result: https://prnt.sc/Rb3P4U8TBibL
    The browser console shows these messages:

    This page uses the non standard property “zoom”. Consider using calc() in the relevant property values, or using “transform” along with “transform-origin: 0 0”. admin.php
    JQMIGRATE: Migrate is installed, version 3.3.2 jquery-migrate.min.js:2:709
    Loading failed for the <script> with source “https://jonathanpopkesbean.com/wp-content/plugins/genesis-blocks/lib/Analytics/js/gaClient.js?ver=1644285732”. admin.php:205:1
    Uncaught ReferenceError: __webpack_require__ is not defined
        <anonymous> webpack:///./lite/admin/js/main.js?:1
        eval https://jonathanpopkesbean.com/wp-admin/admin.php?page=es_gallery&campaign-type=post_notification&ig_es_trial_consent=no&_wpnonce=605c7744a6:59
        js https://jonathanpopkesbean.com/wp-content/plugins/email-subscribers/lite/admin/dist/main.js?ver=2.0.4:108
        __webpack_require__ https://jonathanpopkesbean.com/wp-content/plugins/email-subscribers/lite/admin/dist/main.js?ver=2.0.4:20
        <anonymous> https://jonathanpopkesbean.com/wp-content/plugins/email-subscribers/lite/admin/dist/main.js?ver=2.0.4:84
        <anonymous> https://jonathanpopkesbean.com/wp-content/plugins/email-subscribers/lite/admin/dist/main.js?ver=2.0.4:87
    admin.php:1:1

    I return to the Campaigns screen and click “Create Post Notification”. Result is the same as above — same screen appearance, same console error message.

    Thread Starter Tyler Tork

    (@tylertork)

    Fix confirmed. Thank you.

    Thread Starter Tyler Tork

    (@tylertork)

    As far as I’m concerned the issue is still open. Thank you for acting on it. Since the version containing the fix is not yet available for me to test, I can’t confirm the fix, so there’s nothing for me to add until then.

    Thread Starter Tyler Tork

    (@tylertork)

    I gave you a demo website. Why don’t you look at the page source and you tell me if the theme has removed something. I’m not the expert on what the output is supposed to be.

    Thread Starter Tyler Tork

    (@tylertork)

    I just published a plugin to correct this problem. I still think it should be allowed by the theme. But you do as you see fit.

    Thread Starter Tyler Tork

    (@tylertork)

    Trying it in a fresh install with no other plugins still didn’t find the word in the PDF file, though it did find both occurrences of a word in the post title. Reached out privately as you suggested.

    Thread Starter Tyler Tork

    (@tylertork)

    This corrected the error. Thank you.

    We have purchased the Pro version, but I’ll wait to install it until you confirm the problem has also been fixed there.

Viewing 15 replies - 1 through 15 (of 140 total)